Add macOS and Ninja jobs to GitHub Actions #276
Conversation
| brew install ace asio eigen tinyxml swig qt5 gsl pkg-config jpeg tinyxml | ||
| # Understand how to export env variables in a os-specific way | ||
| export Qt5_DIR=/usr/local/opt/qt5/lib/cmake/Qt5 |
There was a problem hiding this comment.
Curiosity: is this no longer necessary?
There was a problem hiding this comment.
I have no idea, but I wanted to test it.
There was a problem hiding this comment.
Apparently it is not necessary anymore, as the test are successful even without setting it.
There was a problem hiding this comment.
Apparently it is still necessary, as without it the Qt5 GUI are skipped, see in the log:
2019-11-07T17:11:17.9116700Z -- Qt5 and GTK2 not found/selected, skipping iCubSkinGui
2019-11-07T17:11:17.9117690Z -- Qt5 and GTK2 not found/selected, skipping frameGrabberGui2
2019-11-07T17:11:17.9118630Z -- Qt5 and GTK2 not found/selected, skipping skinManagerGui
There was a problem hiding this comment.
@diegoferigo any idea on how to set export Qt5_DIR=/usr/local/opt/qt5/lib/cmake/Qt5 only for a macos runner without duplicating the build step?
There was a problem hiding this comment.
Yes, there's an undocumented method that is all but future proof:
- name: Setting env var
if: matrix.os == macOS-10.14
run: |
echo "::set-env name=Qt5_DIR::/path/to/dir"
envThere was a problem hiding this comment.
Ah cool. For the time being I just set Qt5_DIR to /usr/local/opt/qt5/lib/cmake/Qt5 also in Linux, as /usr/local/opt/qt5/lib/cmake/Qt5 is an empty directory in Linux and qt is found just by using the system paths, but this method may be useful.
There was a problem hiding this comment.
It seems that there are some docs about it, see : https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-an-environment-variable-set-env . Thanks @pattacini for the link.
There was a problem hiding this comment.
Cool, thanks for letting me know! Also the logger support is quite interesting
.github/workflows/ci.yml
Outdated
| run: | | ||
| brew cask install xquartz | ||
| brew install ace asio eigen tinyxml swig qt5 gsl pkg-config jpeg tinyxml |
There was a problem hiding this comment.
'tinyxml' appears twice (actually also in the superbuild README).
What about: boost sqlite libedit ipopt opencv@3 ?
There was a problem hiding this comment.
Thanks, I will make it compatible with the README's one (that however do not contain boost).
|
To avoid being blocked by the Xcode problem, I switched to use Ninja + Make. If the problem is also reproducible with Ninja, it is easier to debug on a Linux machine. |
traversaro
changed the title
traversaro
force-pushed
the
add-macos-ga
branch
from
48f6234
to
4714187
Compare
It is a dependency of ogre.
traversaro
force-pushed
the
add-macos-ga
branch
from
4714187
to
14fa9d9
Compare
|
Rebased on the top of master to also test stable and unstable branches. |
Furthermore, provide a fix for #265 .