Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies for robot-log-visualizer #1624

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

giotherobot
Copy link
Contributor

We were missing some dependencies needed for the robot-log-visualizer.

@traversaro
Copy link
Member

Thanks! For reference qtpy is required by pyqtconsole, and pyqtwebengine is instead a proper robot-log-visualizer dependency.

@traversaro
Copy link
Member

The pip check that I added reported another problem:

DEPRECATION: yarp 3.9.0+9-20240316.1+gitf0e6750c4 has a non-standard version number. pip 24.1 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of yarp or contact the author to suggest that they release a version with a conforming version number. Discussion can be found at https://github.com/pypa/pip/issues/12063
meshcat 0.3.2 requires pyngrok, which is not installed.
Error: Process completed with exit code 1.

pyngrok is not available in apt (see https://repology.org/project/python:pyngrok/versions), so probably we need to add it here. Not sure if it make sense to block the PR on that, but it is relatively easy, we can do that.

@traversaro
Copy link
Member

Cool, now only Apple Silicon builds fail with:

 robot-log-visualizer 0.8.1.dev2 requires pyqt5, which is not installed.
robot-log-visualizer 0.8.1.dev2 requires pyqtwebengine, which is not installed.

not worth enough to block further the PR, let's open a new issue: #1625 .

@traversaro traversaro merged commit c549a27 into robotology:master Mar 27, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants