Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump YARP version in Stable branches to 3.9.0 #1548

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Bump YARP version in Stable branches to 3.9.0 #1548

merged 3 commits into from
Dec 19, 2023

Conversation

traversaro
Copy link
Member

No description provided.

@traversaro traversaro changed the title Bump YARP to v3.9.0 Bump YARP version in Stable branches to 3.9.0 Nov 28, 2023
@traversaro
Copy link
Member Author

Ideally we should merge together with conda-forge/yarp-feedstock#28 .

@traversaro traversaro closed this Nov 28, 2023
@traversaro traversaro reopened this Nov 28, 2023
@traversaro
Copy link
Member Author

traversaro commented Nov 28, 2023

Build is failing as icub-main master does not compile against YARP 3.9.0 :

2023-11-28T22:32:14.9145666Z [91/448] Building CXX object src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/yarp_plugin_icubmod_bcbBattery.cpp.o
2023-11-28T22:32:14.9147362Z FAILED: src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/yarp_plugin_icubmod_bcbBattery.cpp.o 
2023-11-28T22:32:14.9153362Z /usr/bin/c++ -DbcbBattery_EXPORTS -I/__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery -isystem /__w/robotology-superbuild/robotology-superbuild/build/install/include -g -fPIC -std=c++17 -MD -MT src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/yarp_plugin_icubmod_bcbBattery.cpp.o -MF src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/yarp_plugin_icubmod_bcbBattery.cpp.o.d -o src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/yarp_plugin_icubmod_bcbBattery.cpp.o -c src/libraries/icubmod/bcbBattery/yarp_plugin_icubmod_bcbBattery.cpp
2023-11-28T22:32:14.9158656Z In file included from src/libraries/icubmod/bcbBattery/yarp_plugin_icubmod_bcbBattery.cpp:10:
2023-11-28T22:32:14.9161287Z /__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery/bcbBattery.h:48:77: error: 'BATTERY_OK_STANBY' is not a member of 'yarp::dev::IBattery::Battery_status'
2023-11-28T22:32:14.9163353Z      IBattery::Battery_status     battery_status = IBattery::Battery_status::BATTERY_OK_STANBY;
2023-11-28T22:32:14.9164397Z                                                                              ^~~~~~~~~~~~~~~~~
2023-11-28T22:32:14.9165890Z [92/448] Building CXX object src/libraries/icubmod/gazeController/CMakeFiles/gazecontrollerclient.dir/yarp_plugin_icubmod_gazecontrollerclient.cpp.o
2023-11-28T22:32:14.9167853Z [93/448] Building CXX object src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/bcbBattery.cpp.o
2023-11-28T22:32:14.9169226Z FAILED: src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/bcbBattery.cpp.o 
2023-11-28T22:32:14.9175388Z /usr/bin/c++ -DbcbBattery_EXPORTS -I/__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery -isystem /__w/robotology-superbuild/robotology-superbuild/build/install/include -g -fPIC -std=c++17 -MD -MT src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/bcbBattery.cpp.o -MF src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/bcbBattery.cpp.o.d -o src/libraries/icubmod/bcbBattery/CMakeFiles/bcbBattery.dir/bcbBattery.cpp.o -c /__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery/bcbBattery.cpp
2023-11-28T22:32:14.9181110Z In file included from /__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery/bcbBattery.cpp:7:
2023-11-28T22:32:14.9183909Z /__w/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/bcbBattery/bcbBattery.h:48:77: error: 'BATTERY_OK_STANBY' is not a member of 'yarp::dev::IBattery::Battery_status'
2023-11-28T22:32:14.9186082Z      IBattery::Battery_status     battery_status = IBattery::Battery_status::BATTERY_OK_STANBY;
2023-11-28T22:32:14.9187006Z                                                                              ^~~~~~~~~~~~~~~~~
2023-11-28T22:32:14.9188639Z [94/448] Building CXX object src/libraries/icubmod/parametricCalibrator/CMakeFiles/parametricCalibrator.dir/yarp_plugin_icubmod_parametricCalibrator.cpp.o
2023-11-28T22:32:14.9190822Z [95/448] Building CXX object src/libraries/icubmod/parametricCalibrator/CMakeFiles/parametricCalibrator.dir/parametricCalibrator.cpp.o
2023-11-28T22:32:14.9192861Z [96/448] Building CXX object src/libraries/icubmod/gazeController/CMakeFiles/gazecontrollerclient.dir/ClientGazeController.cpp.o
2023-11-28T22:32:14.9194173Z ninja: build stopped: subcommand failed.
2023-11-28T22:32:34.7584432Z [198/248] Performing build step for 'yarp-matlab-bindings'
2023-11-28T22:32:34.7593553Z [1/2] Building CXX object matlab/CMakeFiles/yarpOctaveMex.dir/autogenerated/yarpMATLAB_wrap.cxx.o
2023-11-28T22:32:34.7596125Z /__w/robotology-superbuild/robotology-superbuild/src/yarp-matlab-bindings/matlab/autogenerated/yarpMATLAB_wrap.cxx: In function 'int _wrap_getEnvironment__SWIG_0(int, mxArray**, int, mxArray**)':
2023-11-28T22:32:34.7600182Z /__w/robotology-superbuild/robotology-superbuild/src/yarp-matlab-bindings/matlab/autogenerated/yarpMATLAB_wrap.cxx:6366:37: warning: 'std::__cxx11::string yarp::conf::environment::getEnvironment(const char*, bool*)' is deprecated: Use yarp::conf::environment::get_string() instead [-Wdeprecated-declarations]
2023-11-28T22:32:34.7602807Z    result = yarp::conf::environment::getEnvironment((char const *)arg1,arg2);

See robotology/icub-main#915 .

@traversaro
Copy link
Member Author

Ok, the only remaining failures are in LatestReleases, probably we can just ask for a small patch release of icub-main with the fix for YARP 3.9.0 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant