ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 #1539

Nicogene · 2023-11-24T09:05:24Z

It fixes #1513

traversaro

Some metadata for the newly added dependencies are missing.

cmake/Buildergocub-software.cmake

traversaro · 2023-11-24T11:59:31Z

This change is creating some failures in debian-buster:

2023-11-24T10:47:47.3215825Z Not searching for unused variables given on the command line.
2023-11-24T10:47:47.3217808Z loading initial cache file /__w/robotology-superbuild/robotology-superbuild/build/src/ergocub-software/CMakeFiles/YCMTmp/ergocub-software-cache-Debug.cmake
2023-11-24T10:47:47.3219650Z -- The C compiler identification is GNU 8.3.0
2023-11-24T10:47:47.3220473Z -- The CXX compiler identification is GNU 8.3.0
2023-11-24T10:47:47.3221206Z -- Detecting C compiler ABI info
2023-11-24T10:47:47.3221841Z -- Detecting C compiler ABI info - done
2023-11-24T10:47:47.3222623Z -- Check for working C compiler: /usr/bin/cc - skipped
2023-11-24T10:47:47.3223397Z -- Detecting C compile features
2023-11-24T10:47:47.3224057Z -- Detecting C compile features - done
2023-11-24T10:47:47.3224738Z -- Detecting CXX compiler ABI info
2023-11-24T10:47:47.3225446Z -- Detecting CXX compiler ABI info - done
2023-11-24T10:47:47.3226299Z -- Check for working CXX compiler: /usr/bin/c++ - skipped
2023-11-24T10:47:47.3227066Z -- Detecting CXX compile features
2023-11-24T10:47:47.3227773Z -- Detecting CXX compile features - done
2023-11-24T10:47:47.3229425Z -- Found YCM: /__w/robotology-superbuild/robotology-superbuild/build/install/share/cmake/YCM (found version "0.15.3.6-20231117.5+git266a5a4")
2023-11-24T10:47:47.3231929Z -- Found YARP: /__w/robotology-superbuild/robotology-superbuild/build/install/lib/cmake/YARP (found version "3.8.1+29-20231120.2+gitcdd617efd")
2023-11-24T10:47:47.3234024Z CMake Error at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
2023-11-24T10:47:47.3235330Z   Could NOT find OpenCV (missing: OpenCV_CONFIG) (Required is at least
2023-11-24T10:47:47.3236120Z   version "4.2.0")
2023-11-24T10:47:47.3236930Z Call Stack (most recent call first):
2023-11-24T10:47:47.3238183Z   /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
2023-11-24T10:47:47.3240437Z   /__w/robotology-superbuild/robotology-superbuild/build/install/share/YCM/find-modules/FindOpenCV.cmake:99 (find_package_handle_standard_args)
2023-11-24T10:47:47.3242158Z   src/modules/ergoCubEmotions/CMakeLists.txt:12 (find_package)
2023-11-24T10:47:47.3242744Z 
2023-11-24T10:47:47.3242751Z 
2023-11-24T10:47:47.3243111Z -- Configuring incomplete, errors occurred!

is OpenCV 4.2.0 strictly necessary? Debian Buster only has 3.2.0, but probably we could also considering simply drop Debian Buster.

traversaro · 2023-11-24T12:01:38Z

Also Debian bullseye and Ubuntu 20.04 has some problems:

2023-11-24T10:45:11.4824385Z [4/5] Building CXX object src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o
2023-11-24T10:45:11.4826195Z FAILED: src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o 
2023-11-24T10:45:11.4832293Z /usr/bin/c++  -Isrc/modules/ergoCubEmotions -isystem /__w/robotology-superbuild/robotology-superbuild/build/install/include -isystem /usr/include/opencv4 -g -std=gnu++17 -MD -MT src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o -MF src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o.d -o src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o -c /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp
2023-11-24T10:45:11.4838854Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp: In member function 'virtual bool ErgoCubEmotions::updateModule()':
2023-11-24T10:45:11.4842389Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:153:13: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4844111Z   153 |             pollKey();
2023-11-24T10:45:11.4844562Z       |             ^~~~~~~
2023-11-24T10:45:11.4846407Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:173:13: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4848101Z   173 |             pollKey();
2023-11-24T10:45:11.4848553Z       |             ^~~~~~~
2023-11-24T10:45:11.4850792Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp: In member function 'void ErgoCubEmotions::showTransition(const string&, const string&)':
2023-11-24T10:45:11.4854286Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:219:17: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4855997Z   219 |                 pollKey();
2023-11-24T10:45:11.4856478Z       |                 ^~~~~~~
2023-11-24T10:45:11.4856996Z ninja: build stopped: subcommand failed.

See also #1439 .

traversaro · 2023-11-24T12:06:32Z

Also Debian bullseye and Ubuntu 20.04 has some problems:

2023-11-24T10:45:11.4824385Z [4/5] Building CXX object src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o
2023-11-24T10:45:11.4826195Z FAILED: src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o 
2023-11-24T10:45:11.4832293Z /usr/bin/c++  -Isrc/modules/ergoCubEmotions -isystem /__w/robotology-superbuild/robotology-superbuild/build/install/include -isystem /usr/include/opencv4 -g -std=gnu++17 -MD -MT src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o -MF src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o.d -o src/modules/ergoCubEmotions/CMakeFiles/ergoCubEmotions.dir/ergoCubEmotions.cpp.o -c /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp
2023-11-24T10:45:11.4838854Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp: In member function 'virtual bool ErgoCubEmotions::updateModule()':
2023-11-24T10:45:11.4842389Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:153:13: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4844111Z   153 |             pollKey();
2023-11-24T10:45:11.4844562Z       |             ^~~~~~~
2023-11-24T10:45:11.4846407Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:173:13: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4848101Z   173 |             pollKey();
2023-11-24T10:45:11.4848553Z       |             ^~~~~~~
2023-11-24T10:45:11.4850792Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp: In member function 'void ErgoCubEmotions::showTransition(const string&, const string&)':
2023-11-24T10:45:11.4854286Z /__w/robotology-superbuild/robotology-superbuild/src/ergocub-software/src/modules/ergoCubEmotions/ergoCubEmotions.cpp:219:17: error: 'pollKey' was not declared in this scope
2023-11-24T10:45:11.4855997Z   219 |                 pollKey();
2023-11-24T10:45:11.4856478Z       |                 ^~~~~~~
2023-11-24T10:45:11.4856996Z ninja: build stopped: subcommand failed.

See also #1439 .

Ok pollKey was added in OpenCV 4.5.2 , so this replies to #1539 (comment) .

It fixes #1513

Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>

traversaro · 2024-02-26T14:56:11Z

I am not a big fan of this kind of distro-specific logic, but probably it could make sense to only enable this option based on the OpenCV version.

traversaro · 2024-02-26T15:13:59Z

I am not a big fan of this kind of distro-specific logic, but probably it could make sense to only enable this option based on the OpenCV version.

@Nicogene I modified the PR to explain what I intended, let me know if it is clear, thanks!

Nicogene · 2024-02-26T15:15:10Z

I am not a big fan of this kind of distro-specific logic, but probably it could make sense to only enable this option based on the OpenCV version.

@Nicogene I modified the PR to explain what I intended, let me know if it is clear, thanks!

Yes I think it is the best we can do!

Nicogene requested a review from traversaro November 24, 2023 09:05

Nicogene self-assigned this Nov 24, 2023

traversaro requested changes Nov 24, 2023

View reviewed changes

cmake/Buildergocub-software.cmake Show resolved Hide resolved

cmake/Buildergocub-software.cmake Show resolved Hide resolved

traversaro reviewed Nov 24, 2023

View reviewed changes

cmake/Buildergocub-software.cmake Outdated Show resolved Hide resolved

Nicogene mentioned this pull request Dec 18, 2023

Add depedency of ergocub-software on YARP #1558

Merged

Nicogene and others added 4 commits December 18, 2023 10:09

ergocub-software: compile ergoCubEmotions by default

2259bb9

It fixes #1513

Update cmake/Buildergocub-software.cmake

bdbd378

Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>

Update cmake/Buildergocub-software.cmake

71319f2

Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>

Update cmake/Buildergocub-software.cmake

0bc4d14

Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>

Nicogene force-pushed the Nicogene-patch-1 branch from 831214b to 0bc4d14 Compare December 18, 2023 09:10

Nicogene requested a review from traversaro December 18, 2023 09:10

Update Buildergocub-software.cmake

6f55b14

Update Buildergocub-software.cmake

1d7db36

traversaro changed the title ~~ergocub-software: compile ergoCubEmotions by default~~ ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 Feb 29, 2024

Fix typo

89acbfc

traversaro approved these changes Feb 29, 2024

View reviewed changes

traversaro merged commit 0a13a26 into master Feb 29, 2024
36 of 37 checks passed

traversaro deleted the Nicogene-patch-1 branch February 29, 2024 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 #1539

ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 #1539

Nicogene commented Nov 24, 2023

traversaro left a comment •

edited

Loading

traversaro commented Nov 24, 2023 •

edited

Loading

traversaro commented Nov 24, 2023 •

edited

Loading

traversaro commented Nov 24, 2023

traversaro commented Feb 26, 2024

traversaro commented Feb 26, 2024

Nicogene commented Feb 26, 2024 •

edited

Loading

ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 #1539

ergocub-software: compile ergoCubEmotions by default if OpenCV >= 4.5.2 #1539

Conversation

Nicogene commented Nov 24, 2023

traversaro left a comment • edited Loading

Choose a reason for hiding this comment

traversaro commented Nov 24, 2023 • edited Loading

traversaro commented Nov 24, 2023 • edited Loading

traversaro commented Nov 24, 2023

traversaro commented Feb 26, 2024

traversaro commented Feb 26, 2024

Nicogene commented Feb 26, 2024 • edited Loading

traversaro left a comment •

edited

Loading

traversaro commented Nov 24, 2023 •

edited

Loading

traversaro commented Nov 24, 2023 •

edited

Loading

Nicogene commented Feb 26, 2024 •

edited

Loading