-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved SkinGUI for fingertip #930
Conversation
…on + palm workaround
Need to update also the CMakeList file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of inline comments to address.
A few more comments:
- Do we need also configuration files?
- If you did some tests like showing the results on the GUI, would you be willing to post them here?
here we have an example of configuration file showing all 5 types of layout, one of which activated by touchin the PCB concerning the configuration files:
|
This repo contains icub-specific SW. A better place for the ergoCub conf files is definitely https://github.com/icub-tech-iit/ergocub-software. I would wait for @Nicogene to show up before proceeding in this respect though. |
Please, get aligned with @davidetome for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting the CI before merging.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@simeonedussoni a few comments: please check the author and the copyright of the committed files. add somewhere an explanation about which |
Yes but I have no idea how can the SkinGui load fingertip compiled externally, if they are loaded run-time I am ok to move in ergocub-software |
I meant only the .ini files. |
Ok for me! |
implemented:
fingertip 4L/R
for mk1.1 PCB testingfingertipMID
for 3DMID visualizationfakePalm
with just one virtual taxel with zero gain and size to avoid crashing of the GUI)