Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added calibration 14 in embObjMotionControl manages calib 14 #862

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

valegagge
Copy link
Member

Here we added the code for calibration 14 parameters parsing.

Important note

Even if the calibration 14 parameters hosts both motor encoder info and joint encoder (FAP)info, currently only the data regarding the motor encoder are used: pwmlimit and final_pos.

This PR is related to this fw PR and to this icub-firmware-shared PR

@valegagge
Copy link
Member Author

I updated the required icub-firmware-version: now it is 1.34.1

@pattacini
Copy link
Member

Thanks @valegagge
We'd need to put it in draft until the sister PR is merged, otherwise the PR will fail.

@pattacini pattacini marked this pull request as draft April 7, 2023 06:42
@pattacini pattacini marked this pull request as ready for review April 7, 2023 17:47
@pattacini pattacini merged commit 1909f94 into robotology:devel Apr 7, 2023
@valegagge valegagge deleted the feature/calib14 branch June 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants