BAT updates #487
Merged
BAT updates #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2024
Update CMakeLists.txt with icub_firmware_shared version to 1.38.2
robotology/icub-firmware-shared#95
Merged
Update status bat to uint16_t Add total absorbed current to BAT yarp port Set BAT port voltage as the INPUT voltage Update bat v1.3.4, ems v3.87, mc4plus v3.90, mc2plus 3.69, amc 2.2
MSECode
force-pushed
the
feature/batUpdate
branch
from
29921eb
to
76d4073
Compare
valegagge
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
LGTM.
This PR has been tested on the robot. Here are the results: #476 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the improvements required in #476 .
Changes of this PR:
eOas_battery_timedvalue_tvalid for both BAT and BMS devicesRelated to: