Looking to add a way for the client applications to get the Control Room credential from RCC #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oom credential from RCC - Only in `rcc conf credentials` with both flags `--json` and `--showSecrets` the output JSON will contain the un-smudged secret values - Making this a very deliberate command, so that user must know they are about to get the secrets that are by default always smudged to avoid accidental logging etc.
fabioz
reviewed
Sep 17, 2024
| @@ -36,7 +36,7 @@ var credentialsCmd = &cobra.Command{ | |||
| operations.VerifyAccounts(forceFlag) | |||
| } | |||
| if show && !deleteCredentialsFlag { | |||
| operations.ListAccounts(jsonFlag) | |||
| operations.ListAccounts(jsonFlag, secretsFlag) | |||
There was a problem hiding this comment.
Minor: I think I'd call this showSecretsFlag to go along with the flag in the command line.
| @@ -185,8 +185,14 @@ func smudgeSecrets(accounts accountList) accountList { | |||
| return accounts | |||
| } | |||
|
|
|||
| func ListAccounts(json bool) { | |||
| accounts := smudgeSecrets(findAccounts()) | |||
| func ListAccounts(json bool, secrets bool) { | |||
There was a problem hiding this comment.
Likewise here showSecrets would be a better variable name.
| accounts := findAccounts() | ||
|
|
||
| // Smudge secrets by default, unless explicitly requested otherwise | ||
| if !(json && secrets) { |
There was a problem hiding this comment.
The condition is right, but reading it that way was a bit confusing the first time I read it.
I'd probably write it as: if !showSecrets || !json to understand in both cases it'd enter it a bit easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcc conf credentialswith both flags--jsonand--showSecretsthe output JSON will contain the un-smudged secret values