Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fela-plugin-rtl] Ability to set default direction #673

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

robinweser
Copy link
Owner

@robinweser robinweser commented Feb 19, 2019

Description

Adds the ability to set a default direction when using fela-plugin-rtl in order to use the theme.direction approach for conditional rtl transformation.

Packages

List all packages that have been changed.

  • fela-plugin-rtl

Versioning

Patch (as this should have already been part of the last minor)

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant