Fix theme providers not re-rendering their children #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shouldComponentUpdate
on theme providers prevent them to re-render their children if the provided theme hasn't changed. I understand it might have been added to prevent re-rendering all styled fela components if the theme hasn't changed, but React context uses reference identity to determine when to re-render. After checking, create-inferno-context and preact-context also have the same behaviour.Checklist
Quality Assurance
yarn run format
)yarn run lint
)yarn run test
)yarn run flow
)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.