Skip to content

Commit

Permalink
Fix: Move button labels to span tags (fixes adaptlearning#268)
Browse files Browse the repository at this point in the history
  • Loading branch information
swashbuck committed Jun 27, 2023
1 parent 9dca259 commit 433b7f9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions templates/narrative.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ export default function Narrative(props) {
'btn-icon narrative__controls narrative__controls-left',
!shouldEnableBack && 'is-disabled'
])}
aria-label={backLabel}
aria-disabled={!shouldEnableBack || null}
onClick={onNavigationClicked}
>
<span className="aria-label" dangerouslySetInnerHTML={{ __html: backLabel }} />
<span className="icon" aria-hidden="true" />
</button>

Expand All @@ -113,10 +113,10 @@ export default function Narrative(props) {
'btn-icon narrative__controls narrative__controls-right',
!shouldEnableNext && 'is-disabled'
])}
aria-label={nextLabel}
aria-disabled={!shouldEnableNext || null}
onClick={onNavigationClicked}
>
<span className="aria-label" dangerouslySetInnerHTML={{ __html: nextLabel }} />
<span className="icon" aria-hidden="true" />
</button>

Expand Down Expand Up @@ -226,10 +226,10 @@ export default function Narrative(props) {
'btn-icon narrative__controls narrative__controls-left',
!shouldEnableBack && 'is-disabled'
])}
aria-label={backLabel}
aria-disabled={!shouldEnableBack || null}
onClick={onNavigationClicked}
>
<span className="aria-label" dangerouslySetInnerHTML={{ __html: backLabel }} />
<span className="icon" aria-hidden="true" />
</button>

Expand All @@ -239,10 +239,10 @@ export default function Narrative(props) {
'btn-icon narrative__controls narrative__controls-right',
!shouldEnableNext && 'is-disabled'
])}
aria-label={nextLabel}
aria-disabled={!shouldEnableNext || null}
onClick={onNavigationClicked}
>
<span className="aria-label" dangerouslySetInnerHTML={{ __html: nextLabel }} />
<span className="icon" aria-hidden="true" />
</button>

Expand Down

0 comments on commit 433b7f9

Please sign in to comment.