feat: introduce the 'flyAndZoomTo' event #3639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
boazpoolman
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
flyAndZoomTothat allows both thezoomToandflyToevents to be fired as a single animation.Checklist
I have not updated any documentation just yet, as I wanted to confirm that the maintainers of this package agree with the implementation decisions. For example, the leaflet
flyToevent just allows an extra parameter if you'd also want to handle zoom (source). We could do the same thing for this package, but to prevent a breaking change thezoomLevelwould have to become the 3rd parameter of theflyTofunction, afteranimationDuration, which is not in line with the other events which all have theanimationDurationas the last and optional param.Please let me know if you agree with this PR, or if you'd like me to make any changes.