Allow component tree to be alocated in the heap #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra care must be taken to prevent invalid free() calls when mixing both heap and stack tree allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Componentobjects (and derived) can now be instantiated in the heap (e.g. vianew). Parent components will keep track of their children and delete them when being destroyed themselves. When a component is destroyed, it removes itself from its parent.For components allocated in the stack (e.g. as members of another component) this should have no effect, as they would be deleted automatically in reverse-creation order.
This is inspired by Qt's own tree structure