Show description for boolean fields #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
reviewed
Mar 1, 2017
| <label> | ||
| <input type="checkbox" | ||
| id={id} | ||
| checked={typeof value === "undefined" ? false : value} | ||
| required={required} | ||
| disabled={disabled} | ||
| autoFocus={autofocus} | ||
| title={schema.description} |
There was a problem hiding this comment.
The title attribute should be set on the <label> element, so the tooltip is shown when hovering over the whole widget.
There was a problem hiding this comment.
I removed the title-attribute completely, since it is redundant with the DescriptionField above the input.
| @@ -13,13 +13,18 @@ function CheckboxWidget({ | |||
| }) { | |||
| return ( | |||
| <div className={`checkbox ${disabled ? "disabled" : ""}`}> | |||
| { schema.description | |||
| ? <DescriptionField description={ schema.description }/> | |||
| : null | |||
There was a problem hiding this comment.
Nit: this could be written as
{ schema.description && <DescriptionField description={ schema.description }/> }
|
Thanks for the feedback. Should be good to go now! |
|
Thanks! |
n1k0
added a commit
that referenced
this pull request
Mar 21, 2017
New features * Add support for rows attribute of textarea widget. (#450) * #434 - Render empty array item fields when minItems is specified (#484) * Add a "has-danger" class to the form error list (#502) * Show description for boolean fields (#498) * Fix #488: Add a custom Form ErrorList prop. Bugfixes * Fix impossibility to use stateful ArrayFieldTeplate comp. (#519) * Centralized shouldComponentUpdate handling in SchemaField (#490)
|
Released in v0.44.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
A fix for #435 . I chose to present the description in a similar way like the other fields, with an extra text above the input. The suggested
titlelooked a bit "strange" since it was the only input with that kind of behavior and it would probably have issues in a mobile view.Checklist