Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example of moving required styling to classes so can be controlled with css #280

Closed
wants to merge 3 commits into from

Conversation

kav
Copy link

@kav kav commented Jul 14, 2016

No docs update, just want to show the code changes for the jsfiddle I listed in #275

@mplis-jetsetter
Copy link
Contributor

I'd definitely like to see some way to allow library users to style this kind of stuff through CSS. I know this is just an example so maybe you've considered this, but I think there should still be some default styling. This PR would force every user of this library to add some CSS to get any kind of required/optional styling. Also, should there also be a class like control-label-optional so you can target those elements? Otherwise, it seems like you'd have to use some kind of negative selector if you wanted to just denote the optional elements.

@kav
Copy link
Author

kav commented Jul 17, 2016

100% agree

@n1k0
Copy link
Collaborator

n1k0 commented Jul 18, 2016

Accessibility considerations apart (which are probably a concern here though), we'll eventually move towards a field template system like suggested in #275 (comment); that way people will have a way to provide their very own semantics (like what this patch suggests), while we provide accessible defaults.

@kav
Copy link
Author

kav commented Jul 20, 2016

Seems reasonable though I'd argue some more detailed classing and hinting as above are far more accessible than * at the end of the label so I'd still encourage for something more like that as the default. Happy to address @mplis-jetsetter's concerns if you'd like.

@n1k0
Copy link
Collaborator

n1k0 commented Sep 29, 2016

Templates have landed in #304 and are the recommended way to alter the HTML field semantics.

@n1k0 n1k0 closed this Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants