Skip to content

Commit

Permalink
Merge pull request #19 from TanguyBarthelemy/develop
Browse files Browse the repository at this point in the history
change rjdemetra3 --> rjd3workspace and rjdemetra --> rjdverse
  • Loading branch information
clemasso authored May 8, 2024
2 parents 0ef9608 + 84a4098 commit 2cf44c6
Show file tree
Hide file tree
Showing 7 changed files with 643 additions and 14 deletions.
6 changes: 3 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
* Initial commit


[Unreleased]: https://github.com/rjdemetra/rjd3bench/compare/v2.0.0...HEAD
[2.0.0]: https://github.com/rjdemetra/rjd3bench/releases/tag/v1.0.0...2.0.0
[1.0.0]: https://github.com/rjdemetra/rjd3bench/releases/tag/v1.0.0
[Unreleased]: https://github.com/rjdverse/rjd3bench/compare/v2.0.0...HEAD
[2.0.0]: https://github.com/rjdverse/rjd3bench/releases/tag/v1.0.0...2.0.0
[1.0.0]: https://github.com/rjdverse/rjd3bench/releases/tag/v1.0.0
4 changes: 2 additions & 2 deletions R/benchmark.R
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ cholette<-function(s, t, rho=1, lambda=1, bias="None", conversion="Sum", obsposi
#'
#' @examples
multivariatecholette<-function(xlist, tcvector=NULL, ccvector=NULL, rho=1, lambda=1) {
if(!is.list(xlist) | length(xlist) < 3) {
if (!is.list(xlist) | length(xlist) < 3) {
stop("incorrect argument, first argument should be a list of at least 3 time series")}

#create the input
Expand All @@ -207,7 +207,7 @@ multivariatecholette<-function(xlist, tcvector=NULL, ccvector=NULL, rho=1, lambd
ncc<-length(ccvector)
jcc<-.jarray(ccvector, "java/lang/String")
}
if(ntc+ncc==0) {
if (ntc+ncc==0) {
stop("both constraint types are empty, include at least one temporal or contemporaneous constraint")}

jd_rslt<-.jcall("jdplus/benchmarking/base/r/Benchmarking", "Ljdplus/toolkit/base/r/util/Dictionary;", "multiCholette",
Expand Down
2 changes: 1 addition & 1 deletion R/zzz.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ NULL

.onLoad <- function(libname, pkgname) {

if (! requireNamespace("rjd3toolkit", quietly=TRUE)) stop("Loading rjd3 libraries failed")
if (!requireNamespace("rjd3toolkit", quietly = TRUE)) stop("Loading rjd3 libraries failed")

result <- rJava::.jpackage(pkgname, lib.loc=libname)
if (!result) stop("Loading java packages failed")
Expand Down
6 changes: 1 addition & 5 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,7 @@ Temporal disaggregation

## Installation

<<<<<<< HEAD
Running rjd3 packages requires **Java 17 or higher**. How to set up such a configuration in R is explained [here](https://jdemetra-new-documentation.netlify.app/#Rconfig)
=======
Running rjd3 packages requires Java 17 or higher. How to set up such a configuration in R is explained [here](https://jdemetra-new-documentation.netlify.app/#installing-the-software)
>>>>>>> ef77ccbb461db0e9605c0e64a19b51ea9abfbedd

To get the current stable version (from the latest release):

Expand All @@ -70,4 +66,4 @@ pull requests should include **updated tests** and **updated documentation**. If

## Licensing

The code of this project is licensed under the [European Union Public Licence (EUPL)](https://joinup.ec.europa.eu/page/eupl-text-11-12).
The code of this project is licensed under the [European Union Public Licence (EUPL)](https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12).
Loading

0 comments on commit 2cf44c6

Please sign in to comment.