io: return error when reading/writing to unmapped memory #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit on_map_skyline returned true even when the callback was not called on any part of the skyline. In other words, reading/writing to an unmapped memory returned true. This commit changes the behaviour to return false in those cases.
ret2libc
requested review from
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Before this commit on_map_skyline returned true even when the callback was not called on any part of the skyline. In other words, reading/writing to an unmapped memory returned true. This commit changes the behaviour to return false in those cases.
ret2libc
force-pushed
the
fix-insert-bytes
branch
from
c55b10d
to
9452404
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…g true"" This reverts commit 58df9e4.
|
Yes but wait please, I put it in draft mode because I want to review a bit. |
XVilka
approved these changes
Feb 11, 2023
wargio
approved these changes
Feb 11, 2023
XVilka
pushed a commit
that referenced
this pull request
Feb 12, 2023
* core: 'wow' command was replaced with 'wb' * io: on_map_skyline returns false when nothing was done Before this patch on_map_skyline returned true even when the callback was not called on any part of the skyline. In other words, reading/writing to an unmapped memory returned true. This commit changes the behaviour to return false in those cases. * analysis/esil: mem_read/mem_write were alway returning true * use o malloc instead of oC * librz: deal with seek errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
See commits.
Test plan
See steps in #2871 .
Closing issues
Closes #2871