Make afs respect the cc (Fix #3291) #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
requested review from
XVilka,
wargio,
kazarmy and
ret2libc
as code owners
XVilka
approved these changes
Jan 14, 2023
|
suggestions welcome |
|
No better idea either, TBH. Maybe other people could come with it? |
wargio
requested changes
Jan 15, 2023
LaylBongers
reviewed
Jan 15, 2023
thestr4ng3r
requested review from
LaylBongers and
wargio
and removed request for
LaylBongers
Applying a function signature with afs to a function was using a combination of the existing args and wrong stack addresses to apply the args to function variables. This generally resulted in incorrect locations. Instead, we now use the info from the cc.
XVilka
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Applying a function signature with afs to a function was using a combination of the existing args and wrong stack addresses to apply the args to function variables. This generally resulted in incorrect locations. Instead, we now use the info from the cc.
Test plan
see the added test and issue noted below
Closing issues
Fix #3291