build: fix BINDIR_DEPTH computation on Windows #3075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Before there was a special case for the root dir and it was implemented by using
os.sep
as the representation for the root. That did not work on Windows. This commit rewrite the BINDIR_DEPTH computation's logic to use Path objects instead.Test plan
Before the patch RZ_LIBDIR was like
C:\bin\lib
, but the correct value should beC:\bin
.Closing issues
...