Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple vulnerabilities #2977

Merged
merged 20 commits into from
Aug 24, 2022
Merged

Fix multiple vulnerabilities #2977

merged 20 commits into from
Aug 24, 2022

Conversation

wargio
Copy link
Member

@wargio wargio commented Aug 23, 2022

DO NOT SQUASH

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fix #2974
Fix #2973
Fix #2972
Fix #2971
Fix #2970
Fix #2969
Fix #2968
Fix #2967
Fix #2966
Fix #2965
Fix #2964
Fix #2963
Fix #2962
Fix #2961
Fix #2960
Fix #2959
Fix #2958
Fix #2957
Fix #2956
Fix #2955
Fix #2954
Fix #2953
Fix #2952

@wargio wargio mentioned this pull request Aug 23, 2022
Closed
5 tasks
@wargio
Copy link
Member Author

wargio commented Aug 23, 2022

@m4drat please check again from this branch.

@XVilka XVilka added this to the 0.4.1 milestone Aug 23, 2022
@m4drat
Copy link

m4drat commented Aug 23, 2022

@m4drat please check again from this branch.

Got new crash, that was not reproducible on the previous branch (fix-multiple-vulns): #2966 (comment)

XVilka
XVilka approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good even AS IS but I added a few comments as well.

librz/bin/format/mach0/coresymbolication.c Show resolved Hide resolved
librz/bin/format/ne/ne.c Show resolved Hide resolved
librz/bin/format/ne/ne.c Outdated Show resolved Hide resolved
librz/bin/p/bin_qnx.c Show resolved Hide resolved
librz/include/rz_bin_dwarf.h Show resolved Hide resolved
librz/util/asn1.c Outdated Show resolved Hide resolved
@XVilka XVilka merged commit e3a9a3a into dev Aug 24, 2022
@XVilka XVilka deleted the fuzz-fix-multiple-vulns branch August 24, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API DEX DWARF Mach-O PE RzAnalysis RzBin RzCore RzMagic RzUtil
Projects
None yet
Milestone
0.4.1
3 participants
@wargio @m4drat @XVilka