Fix Windows cross build #2897
Merged
Fix Windows cross build #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes `rz_util/rz_version.h`->`rz_types.h`->`rz_userconf.h`->`rz_util/rz_version.h`
GustavoLCR
requested review from
ret2libc,
thestr4ng3r,
wargio,
XVilka and
kazarmy
as code owners
wargio
approved these changes
Aug 10, 2022
kazarmy
approved these changes
Aug 10, 2022
| @@ -513,7 +513,7 @@ if packager_version != '' | |||
| endif | |||
| rz_version_h = configure_file( | |||
| input: 'librz/include/rz_version.h.in', | |||
| output: 'rz_version.h', | |||
| output: 'rz_build_version.h', | |||
There was a problem hiding this comment.
The build should work even if there are 2 different rz_version.h files because they are in different folders (one is in include/ and one is in include/rz_util/), but I'm fine with renaming one of them.
XVilka
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Building for Windows ARM64 broke, this fixes it.
Test plan
Tested manually
Closing issues
None