Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows and cpp compatibility #2887

Merged
merged 10 commits into from
Aug 8, 2022
Merged

Fix windows and cpp compatibility #2887

merged 10 commits into from
Aug 8, 2022

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Aug 8, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

rizinorg/cutter#3008

Test plan

...

Closing issues

...

@github-actions github-actions bot added the API label Aug 8, 2022
@XVilka XVilka requested a review from GustavoLCR August 8, 2022 00:18
@github-actions github-actions bot added the RzUtil label Aug 8, 2022
@XVilka XVilka requested a review from ret2libc August 8, 2022 08:16
ret2libc
ret2libc approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you already check it with Cutter?

@imbillow
Copy link
Contributor Author

imbillow commented Aug 8, 2022

LGTM. Did you already check it with Cutter?

YES

@wargio wargio merged commit 215e492 into dev Aug 8, 2022
@wargio wargio deleted the billow/fix branch August 8, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio wargio approved these changes

@ret2libc ret2libc ret2libc approved these changes

@thestr4ng3r thestr4ng3r thestr4ng3r approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@GustavoLCR GustavoLCR Awaiting requested review from GustavoLCR

Assignees
No one assigned
Labels
API RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imbillow @XVilka @wargio @ret2libc @thestr4ng3r