Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on every build the git hash shown by rizin -v #2863

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Aug 1, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr updates on every build the git commit hash shown by rizin -v. Previously, the updating was done only on a meson configure, which doesn't happen on every commit and thus the git commit hash shown can sometimes be out-of-date.

Currently Python is used for the updating of the gittip file containing the commit hash. This shouldn't be too much of a burden though since Python is needed for meson and therefore should be in the cache.

Test plan

After this code is installed, add a new commit that doesn't cause build file regeneration. The commit hash shown by rizin -v should be the hash of the new commit. All builds are green.

Closing issues

...

@kazarmy kazarmy merged commit fc24887 into rizinorg:dev Aug 1, 2022
wingdeans pushed a commit to wingdeans/rizin that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants