Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print.c refactor #2841

Merged
merged 8 commits into from
Jul 27, 2022
Merged

print.c refactor #2841

merged 8 commits into from
Jul 27, 2022

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Jul 26, 2022 •
edited by XVilka
Loading

SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

1/n of #2813

Test plan

...

Closing issues

...

ret2libc
ret2libc reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the previous PR! It is very much appreciated and much easier to review now, thanks!

I think overall it is a good change, just added some minor things.
Thanks again!

librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/io/p/io_gprobe.c Outdated Show resolved Hide resolved
librz/util/print.c Show resolved Hide resolved
librz/util/print.c Show resolved Hide resolved
librz/util/print.c Show resolved Hide resolved
librz/include/rz_util/rz_print.h Show resolved Hide resolved
librz/include/rz_util/rz_print.h Show resolved Hide resolved
imbillow and others added 2 commits July 27, 2022 12:09
@imbillow
dedup code
289e7b6
@imbillow @ret2libc
Apply suggestions from code review
e1151c1 
Co-authored-by: Riccardo Schirone <ret2libc@users.noreply.github.com>
@XVilka XVilka merged commit df60294 into dev Jul 27, 2022
@XVilka XVilka deleted the asan_print_refactor branch July 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio left review comments

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc ret2libc approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API merge-when-green rz-find RzCore RzIO RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imbillow @XVilka @wargio @ret2libc