Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rz_th_kill, rz_th_kill_free and rz_th_pool_kill #2790

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Conversation

wargio
Copy link
Member

@wargio wargio commented Jul 7, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@thestr4ng3r
Copy link
Member

RzThreadBool is not a very good name imo. What about calling it RzAtomicBool and adding a documentation comment that right now it's just super barebones and the "real" atomic ops like cas can be added later, as well as implementations without locks?

@wargio wargio merged commit 522ab57 into dev Jul 8, 2022
@wargio wargio deleted the remove-rz-th-kill branch July 8, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants