Add RzBaseFindOpt for custom thread status callback #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
requested review from
ret2libc,
thestr4ng3r,
XVilka and
kazarmy
as code owners
wargio
changed the title
XVilka
approved these changes
Jul 3, 2022
ret2libc
reviewed
Jul 3, 2022
ret2libc
reviewed
Jul 4, 2022
librz/include/rz_basefind.h
Outdated
Comment on lines
27
to
29
| ut64 begin_address; ///< Thread begin address | ||
| ut64 current_address; ///< Thread current address | ||
| ut64 end_address; ///< Thread end address |
There was a problem hiding this comment.
What is the "thread begin address'?
There was a problem hiding this comment.
each thread has a range to scan, that is the thread range
There was a problem hiding this comment.
ok maybe be a bit more explicit about this in the doc for these fields.
Moreover, from a more high level point of view, why do we care about the details? I mean, do we really need to export the information about threads running the search? Are you planning to export this info in cutter?
wargio
force-pushed
the
basefind-cutter-api
branch
from
855670b
to
b177358
Compare
wargio
force-pushed
the
basefind-cutter-api
branch
from
9c32e30
to
09629a5
Compare
ret2libc
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Add RzBaseFindOpt to allow to have custom thread status callbacks