Fixing compilation warnings on SystemZ #2549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DurzaShade
commented
Apr 18, 2022
| @@ -1450,7 +1450,7 @@ static int rz_debug_native_bp(RzBreakpoint *bp, RzBreakpointItem *b, bool set) { | |||
| return set | |||
| ? arm32_hwbp_add(dbg, bp, b) | |||
| : arm32_hwbp_del(dbg, bp, b); | |||
| #elif __riscv | |||
| #elif __riscv || __s390__ || __s390x__ || __zarch__ | |||
There was a problem hiding this comment.
Added the pre-processor macros for SystemZ as per https://sourceforge.net/p/predef/wiki/Architectures/
|
To be honest, I expected the fix the "right way" - adding the support instead of disabling it. |
this is currently just a placeholder PR, that I raised for my GSoC application. I am planning to update it with the fix for #297 |
|
I am closing this. If you plan to do the proper fix - please open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
SystemZ had compilation warnings. This PR partially addresses the warnings.
...
Test plan
...
Closing issues
...