-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite PDB parser #1517
Rewrite PDB parser #1517
Conversation
3a13542
to
39cf7dd
Compare
6ba3e2d
to
dcea9dd
Compare
9d3975a
to
bcac6ed
Compare
It makes SystemZ unit tests pass: https://app.travis-ci.com/github/rizinorg/rizin/jobs/537216040#L3041 We have a long road to fix all integration tests though...:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some small regressions related to the missing classes support in RzType and missing bitfields support in RzType but it's already a huge improvement over the old code. I think we should merge it as is.
This comment has been minimized.
This comment has been minimized.
3925afb
to
7033456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ret2libc your last comment was addressed, please take a look again, and lets not wait anymore and merge if green.
7033456
to
cc13b06
Compare
cc13b06
to
da3deb9
Compare
Please fix the WIndows linking error:
|
I broke the Travis PPC and ARM tests:
|
cc2fdda
to
723a2c6
Compare
Two ASAN failed tests are unrelated to this PR and happen on the latest
|
Your checklist for this pull request
Detailed description
Test plan
CI is green.
Closing issues
Closes #279, partially addresses #297
TODO
rz_bin_pdb_gvars_as_cmd_string
and just use the proper API instead of creating commands + execute themrz_bin_pdb_types_as_string