Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joystick animation not working #331

Closed
edhom opened this issue Jul 12, 2023 · 2 comments
Closed

Joystick animation not working #331

edhom opened this issue Jul 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@edhom
Copy link

edhom commented Jul 12, 2023

Description

It seems like joystick animations don't work as expected for us in Flutter runtime. In the animation below, the water should move up as the key moves in... Are we missing anything?

Steps To Reproduce

Demo App
void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Joystick Demo',
      home: Scaffold(
        body: Container(
          color: Colors.black87,
          child: const Center(
            child: RiveAnimation.asset(
              'joysticks.riv',
              fit: BoxFit.contain,
              stateMachines: ['State Machine'],
            ),
          ),
        ),
      ),
    );
  }
}

Source .riv/.rev file

https://editor.rive.app/file/key-joystick/459047

joystick_demo.zip

Actual behavior

Screen.Recording.2023-07-11.at.14.45.00.mov

Expected behavior

Water moves up

Device & Versions (please complete the following information)

  • Rive: ^0.11.3

  • Device: iOS Simulator, Web

  • OS: iOS 16.0

Flutter 3.10.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 796c8ef792 (4 weeks ago) • 2023-06-13 15:51:02 -0700
Engine • revision 45f6e00911
Tools • Dart 3.0.5 • DevTools 2.23.1
@edhom edhom added the bug Something isn't working label Jul 12, 2023
@HayesGordon
Copy link
Contributor

Thanks for opening the issue. We're looking into it

rive-engineering pushed a commit that referenced this issue Jul 19, 2023
Fixes #331

An inconsistency between the editor and Flutter runtime. External control on a Joystick was not applied.

I used this file to reproduce and test: [joystickdemo2.rev.zip](https://github.com/rive-app/rive/files/12051102/joystickdemo2.rev.zip)

Expected behaviour (the handle is controlled by the position of the top rectangle):

https://github.com/rive-app/rive/assets/13705472/1eae3a71-5f2d-4375-a531-d36b61e5cc61

Diffs=
44f6c4b9c fix: joystick handleSource not enabled for flutter runtime (#5589)
d1f8710f5 Fix dependency order issues for Follow Path (#5595)

Co-authored-by: Gordon <pggordonhayes@gmail.com>
@HayesGordon
Copy link
Contributor

Fixed in v0.11.5

edhom added a commit to simpleclub-extended/rive-flutter that referenced this issue Jul 24, 2023
Fixes rive-app#331

An inconsistency between the editor and Flutter runtime. External control on a Joystick was not applied.

I used this file to reproduce and test: [joystickdemo2.rev.zip](https://github.com/rive-app/rive/files/12051102/joystickdemo2.rev.zip)

Expected behaviour (the handle is controlled by the position of the top rectangle):

https://github.com/rive-app/rive/assets/13705472/1eae3a71-5f2d-4375-a531-d36b61e5cc61

Diffs=
44f6c4b9c fix: joystick handleSource not enabled for flutter runtime (#5589)
d1f8710f5 Fix dependency order issues for Follow Path (#5595)

Co-authored-by: Gordon <pggordonhayes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants