refactor(iceberg): extract IcebergCommon config #18600
Merged
+737
−636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
force-pushed
the
09-18-refactor_connector_extract_icebergcommon_config
branch
from
4abecd7
to
c6f0441
Compare
xxchan
force-pushed
the
09-18-refactor_connector_extract_icebergcommon_config
branch
from
ff19cec
to
71539bd
Compare
xxchan
changed the title
Li0k
reviewed
Sep 19, 2024
| .unwrap_or_else(|| "risingwave".to_string()) | ||
| } | ||
|
|
||
| pub fn full_table_name(&self) -> ConnectorResult<TableIdentifier> { |
There was a problem hiding this comment.
how about move full_table_name to v1 ? It use icelake::TableIdentifier
Signed-off-by: xxchan <xxchan22f@gmail.com>
tabVersion
approved these changes
Sep 20, 2024
Comment on lines
+43
to
+49
| pub region: Option<String>, | ||
| #[serde(rename = "s3.endpoint")] | ||
| pub endpoint: Option<String>, | ||
| #[serde(rename = "s3.access.key")] | ||
| pub access_key: String, | ||
| #[serde(rename = "s3.secret.key")] | ||
| pub secret_key: String, |
There was a problem hiding this comment.
referencing this part to AwsAuthProps instead?
There was a problem hiding this comment.
They are incompatible and this PR doesn't want to change behavior
xxchan
deleted the
09-18-refactor_connector_extract_icebergcommon_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously, we use
sink/IcebergConfigfor both source and sink, which is confusing. This PRsource::IcerbergPropertiestosink::IcebergConfigNote: currently source and sink has some differences:
This PR tries to be an equivalent refactor and so doesn't change any of these.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.