Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: predict words longer than 4 syllables #832

Merged
merged 6 commits into from
Mar 3, 2024
Merged

feat: predict words longer than 4 syllables #832

merged 6 commits into from
Mar 3, 2024

Conversation

lotem
Copy link
Member

@lotem lotem commented Mar 2, 2024 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

work in progress:

  • static dictionary supports predictive word query.
  • user dictionary has not yet implemented this feature.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

ksqsf
ksqsf approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lotem lotem merged commit eca939c into rime:master Mar 3, 2024
9 checks passed
@lotem lotem deleted the predict-word branch March 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lotem @ksqsf