Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clang format in rime source code #815

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

Bambooin
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
Apply clang format in rime source code.

Add targets in Makefile, to format code, just use command.

make clang-format-apply

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Since clang format 14 package in ubuntu is outdated.
@Bambooin Bambooin force-pushed the code-style branch 2 times, most recently from c477e72 to e4ce4a6 Compare February 11, 2024 13:56
@eagleoflqj eagleoflqj merged commit 3368db1 into rime:master Feb 12, 2024
18 checks passed
@Bambooin Bambooin deleted the code-style branch March 12, 2024 11:14
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants