Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side calibration expansion #1288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Client side calibration expansion #1288

wants to merge 4 commits into from

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Dec 16, 2020 •
edited
Loading

Description

Perform Quil-T calibration expansion on the client. Optionally force calibration to occur on the translation service with expand_calibrations=False.

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

@notmgsk notmgsk force-pushed the client-side-calibration-expansion branch from 040485e to 46658fb Compare December 16, 2020 20:04
@notmgsk notmgsk marked this pull request as ready for review December 16, 2020 20:06
@notmgsk notmgsk requested a review from a team as a code owner December 16, 2020 20:06
@notmgsk notmgsk force-pushed the client-side-calibration-expansion branch from 46658fb to fb529b6 Compare December 28, 2020 13:53
kalzoo
kalzoo requested changes Dec 28, 2020
View reviewed changes
pyquil/api/_compiler.py
@@ -425,6 +431,20 @@ def calibration_program(self) -> Program:
else:
return self._calibration_program

def expand_calibrations(self, program: Program, discard_defcals: bool = True) -> Program:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this logic should be on Program, or in a standalone function, for use where a QPUCompiler doesn't make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notmgsk @kalzoo