Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(bonfire) Ensure cache is populated before calculating permissions #259

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

TheBobBobs
Copy link
Contributor

@TheBobBobs TheBobBobs commented Jun 19, 2023

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects

Fixes clients not receiving ChannelCreate event if channel was not already present in cache.

Insert members and servers into cache before filtering channels to prevent fetching them for every channel.
Closes #231

@TheBobBobs TheBobBobs changed the title fix:(bonfire) fetch channel to calc perms for ChannelUpdate event fix:(bonfire) Ensure cache is populated before calculating permissions Jun 21, 2023
@insertish insertish merged commit 6e4798f into revoltchat:master Jul 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

issue: restoring view permissions on channel on a role does not propagate to client
2 participants