Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(revery): bump dependencies and OCaml 4.12 #1066

Merged
merged 3 commits into from
May 11, 2021
Merged

chore(revery): bump dependencies and OCaml 4.12 #1066

merged 3 commits into from
May 11, 2021

Conversation

EduardoRFS
Copy link
Member

Changes

  • Removed ocamlformat, it was not being used anywhere
  • Pinned reason because of the wrong published version constraint
  • Bumped Lwt to 5.x.x
  • Bumped OCaml to 4.12
  • Removed resolution on conf-pkg-config, it was already fixed on esy-opam-overrides

@EduardoRFS EduardoRFS requested review from zbaylin and bryphe May 11, 2021 08:12
bryphe
bryphe approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@bryphe bryphe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks for upgrading all these dependencies @EduardoRFS ! (and cleaning up some unnecessary deps...)

I just updated the bench/test lockfiles via the ./update-lockfiles.sh script - those were causing the hygiene check failure. Will merge once the CI is green 👍

@bryphe bryphe mentioned this pull request May 11, 2021
Merged
@bryphe bryphe merged commit 2844083 into revery-ui:master May 11, 2021
@bryphe
Copy link
Member

bryphe commented May 11, 2021

Thanks @EduardoRFS !

bryphe added a commit to onivim/oni2 that referenced this pull request May 12, 2021
@bryphe
refactor(dependency): ocaml -> 4.11 (#3531)
1228d37 
Gotta get Onivim caught up with: revery-ui/revery#1066

This also will let us start using `memtrace` (since 4.11 has the `Gc.Memprof` apis) which will be really helpful for perf: https://github.com/janestreet/memtrace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryphe bryphe bryphe approved these changes

@zbaylin zbaylin Awaiting requested review from zbaylin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardoRFS @bryphe