Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTEASY-2431 / create an example called resteasy-spring-undertow #47

Merged
merged 9 commits into from
Feb 13, 2020

Conversation

liweinan
Copy link
Contributor

No description provided.

Copy link
Member

@asoldano asoldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liweinan I see a testcase got removed and a main class is added and referenced in the example documentation. While this is fine for the final user, it's not ideal for us, as the example is not tested as part of the build, is it?
Would it be possible to add a testcase here?

@liweinan
Copy link
Contributor Author

@asoldano Okay! Instead of keeping it into resteasy-spring-mvc, I have added the test case back into resteasy-spring-undertow and rewrite it.

Because the resteasy-spring-basic, resteasy-spring-mvc, resteasy-spring-customized examples shows the spring integration with servlet container running in a standalone scenario.

If we do need test cases for it, we should test the same scenario as the example shows. For resteasy-spring-basic and resteasy-spring-customized, we should use Arquillian for testing. For resteasy-spring-mvc test, it contains a frontend jsp page for testing, so we need something like testcontainer+selenium for testing. If we do need it, I can create JIRA issues to track the tasks. And for this PR we finish it by here. wdyt?

@asoldano
Copy link
Member

@liweinan OK, fine, let's go with what we have here so far.

@liweinan
Copy link
Contributor Author

@asoldano okay! The future work will be put into https://issues.redhat.com/browse/RESTEASY-2498

@liweinan liweinan merged commit 9707210 into resteasy:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants