Skip to content

Commit

Permalink
feat: update to node 20 (#404)
Browse files Browse the repository at this point in the history
BREAKING CHANGES: Switch to Node20 runtime
  • Loading branch information
prescottprue authored Feb 23, 2024
1 parent a25e776 commit 9f7a723
Show file tree
Hide file tree
Showing 19 changed files with 36,300 additions and 14,168 deletions.
24 changes: 7 additions & 17 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,27 +35,17 @@ module.exports = {
tsx: 'never',
},
],
// NOTE: This is added since eslint-plugin-import does not support exports in package.json
// which is what firebase-admin v10 uses. See: https://github.com/import-js/eslint-plugin-import/issues/1810
'import/no-unresolved': [
2,
{
ignore: [
'firebase-admin/database',
'firebase-admin/app',
'firebase-admin/auth',
'firebase-admin/storage',
'firebase-admin/firestore',
],
},
],
},
overrides: [
{
files: ['./jest.setup.js'],
extends: ['@side/jest'],
files: ['./vitest.config.ts'],
rules: {
'@typescript-eslint/no-var-requires': 0,
'import/no-unresolved': [
'error',
{
ignore: ['^vitest/.+'],
},
],
},
},
],
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand All @@ -49,7 +49,7 @@ jobs:
run: yarn lint

- name: Test
run: yarn test --coverage --silent --coverageReporters lcov --coverageReporters json-summary
run: yarn test --coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:
cancel-in-progress: true

env:
NODE_VERSION: 16.x
NODE_VERSION: 20.x

jobs:
build:
Expand All @@ -24,7 +24,7 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand All @@ -48,7 +48,7 @@ jobs:
run: yarn lint

- name: Test
run: yarn test --coverage --silent --coverageReporters lcov --coverageReporters json-summary
run: yarn test --coverage

- name: Upload coverage to Coveralls
uses: coverallsapp/github-action@v2
Expand Down
3 changes: 0 additions & 3 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn commitlint --edit $1
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn lint-staged && yarn build && git add dist
875 changes: 0 additions & 875 deletions .yarn/releases/yarn-3.8.0.cjs

This file was deleted.

893 changes: 893 additions & 0 deletions .yarn/releases/yarn-4.1.0.cjs

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
compressionLevel: mixed

enableGlobalCache: false

nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-3.8.0.cjs
yarnPath: .yarn/releases/yarn-4.1.0.cjs
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ inputs:
description: 'Flag name'
required: false
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
post-if: 'success()'
Loading

0 comments on commit 9f7a723

Please sign in to comment.