fix: define default units for fields #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelwnaylor
force-pushed
the
default-units-for-fields
branch
from
4fdf05b
to
d6d1291
Compare
aclerc
requested changes
Sep 25, 2024
samuelwnaylor
force-pushed
the
default-units-for-fields
branch
from
d6d1291
to
26db0a0
Compare
Addressed in commit ddf52fb |
Use default units in the plots. This removes some of the hard-coded strings, therefore mitigating typos of units. Fixes #27
samuelwnaylor
force-pushed
the
default-units-for-fields
branch
from
26db0a0
to
ddf52fb
Compare
aclerc
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default units in the plots. This removes some of the hard-coded strings, therefore mitigating typos of units in axis labels on plots.
Fixes #27