Feature/check for archive #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclerc
approved these changes
Jun 26, 2024
| logger.info(f"Failed to download Zenodo record {record_id}. Error: {e}") | ||
|
|
||
| if (output_dir / "SMARTEOLE-WFC-open-dataset.zip").exists(): | ||
| logger.info("Using cached dataset.") |
There was a problem hiding this comment.
this message could include {output_dir / "SMARTEOLE-WFC-open-dataset.zip"} to make it super obvious what has happened but no big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aclerc, I'm just getting familiarized with wind-up and as one learning activity I wanted to try submitting a PR activity from my fork. Feel free to reject the change though, the main thing this code does is allow the examples to proceed in the event the user can't connect to zenodo (it is blocked by our firewall), if the file is already located in the CACHE folder.
Then a much smaller change, I added DS_Store to the list of files to ignore (some kind of mac temp file)