Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect format of function under unary operator #6953

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Fix incorrect format of function under unary operator #6953

merged 5 commits into from
Aug 16, 2024

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Aug 16, 2024

Fix #6884

@shulhi shulhi marked this pull request as ready for review August 16, 2024 01:55
@shulhi shulhi requested a review from cknitt August 16, 2024 02:58
cknitt
cknitt approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot! 👍

@cknitt cknitt merged commit 4a1fbf3 into rescript-lang:master Aug 16, 2024
20 checks passed
@shulhi shulhi deleted the fix-parens branch August 16, 2024 05:42
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Sep 8, 2024
@shulhi @cknitt
Fix incorrect format of function under unary operator (rescript-lang#…
0b4b20f 
…6953)

* Fix parens in unary operator

* Fix parens in binary expr

* Handle underscore sugar application

* Add tests

* Update CHANGELOG
cknitt pushed a commit to cknitt/rescript-compiler that referenced this pull request Sep 8, 2024
@shulhi @cknitt
Fix incorrect format of function under unary operator (rescript-lang#…
b6f137f 
…6953)

* Fix parens in unary operator

* Fix parens in binary expr

* Handle underscore sugar application

* Add tests

* Update CHANGELOG
cknitt pushed a commit that referenced this pull request Sep 10, 2024
@shulhi @cknitt
Fix incorrect format of function under unary operator (#6953)
680d0ad 
* Fix parens in unary operator

* Fix parens in binary expr

* Handle underscore sugar application

* Add tests

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect print of function under unary operator
2 participants
@shulhi @cknitt