self-review

rerun-io · Jan 8, 2024 · 6dde31c · 6dde31c
1 parent 3882013
commit 6dde31c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/crates/re_query_cache/benches/latest_at.rs b/crates/re_query_cache/benches/latest_at.rs
@@ -279,7 +279,7 @@ fn query_and_visit_points(store: &DataStore, paths: &[EntityPath]) -> Vec<SavePo
     // TODO(jleibs): Add Radius once we have support for it in field_types
     for path in paths {
         query_archetype_pov1_comp1::<Points2D, Position2D, Color, _>(
-            true,
+            true, // cached?
             store,
             &query.clone().into(),
             path,
@@ -310,7 +310,7 @@ fn query_and_visit_strings(store: &DataStore, paths: &[EntityPath]) -> Vec<SaveS
 
     for path in paths {
         query_archetype_pov1_comp1::<Points2D, Position2D, Text, _>(
-            true,
+            true, // cached?
             store,
             &query.clone().into(),
             path,

diff --git a/crates/re_query_cache/src/query.rs b/crates/re_query_cache/src/query.rs
@@ -98,7 +98,7 @@ macro_rules! impl_query_archetype {
             );
 
             let mut latest_at_callback = |query: &LatestAtQuery, cache: &mut crate::LatestAtCache| {
-                re_tracing::profile_scope!("latest_at");
+                re_tracing::profile_scope!("latest_at", format!("{query:?}"));
 
                 let bucket = cache.entry(query.at).or_default();
                 // NOTE: Implicitly dropping the write guard here: the LatestAtCache is free once again!

diff --git a/crates/re_query_cache/tests/latest_at.rs b/crates/re_query_cache/tests/latest_at.rs
@@ -218,7 +218,7 @@ fn query_and_compare(store: &DataStore, query: &LatestAtQuery, ent_path: &Entity
         let mut got_colors = Vec::new();
 
         query_archetype_pov1_comp1::<Points2D, Position2D, Color, _>(
-            true,
+            true, // cached?
             store,
             &query.clone().into(),
             ent_path,