chore(angular): update to Angular@16 #144
Merged
+4,306
−3,494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCHAPLIN
force-pushed
the
chore/update-angular-16
branch
from
4be0c5b
to
1a4c5c1
Compare
|
This looks good to me as well |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request aims to update the lib to allow it's use with Angular v16.
What I did :
I identified a minor change in the component style : the drop shadow is thinner on cards. This is normal according the MDC spec (see https://material.angular.io/guide/mdc-migration#library-wide-changes and https://m3.material.io/components/cards/overview.
Could you please review this soon ? I really need ngx-drag-drop to support ng16...
Thank you !
closes #143