[#2196] Use git blame line info for aggregate blame author modified and date info #2232

logical-1985516 · 2024-07-03T16:28:51Z

Proposed commit message

Uses blameLine to abstract away the string wrangling and improve
understandability. Magic numbers are also replaced to improve code
quality.

In order to use blameLine however, it is also changed to use 
author-time instead of commit-time, as there is a discrepancy
between the two, causing some test cases to fail.

The naming of the timestamp field in GitBlameLineInfo is changed
to reflect that it is in seconds, as author-time is in seconds.

Other information

Surrounding code which states milliseconds is also changed to state seconds correctly, as this PR is meant to resolve a code quality issue anyways. If this is not ok, I can revert the last commit.

logical-1985516 · 2024-07-07T16:59:45Z

Hi, I have noticed that some test cases take a very long time to finish. Could this be due to the additional overhead incurred from running git blame command in blameLine?

…meAuthorModifiedAndDateInfo

logical-1985516 · 2024-07-15T10:24:00Z

Hi, would anyone like to approve the workflow? I am not sure why the local test cases run indefinitely, so I am unable to verify that it passes all test cases. Thank you!

damithc · 2024-07-15T11:58:37Z

Hi, would anyone like to approve the workflow? I am not sure why the local test cases run indefinitely, so I am unable to verify that it passes all test cases. Thank you!

done

logical-1985516 · 2024-07-17T14:51:54Z

Hi, would anyone like to help me for this issue? I could not seem to figure why the test cases are failing. More information at this discussion.

…meAuthorModifiedAndDateInfo

src/main/java/reposense/git/GitBlame.java

This is because blameFile already uses split to return String[]. This change allows the removal of the awkward String wrangling in blameFile. The split function in processGitBlameResultLine has been moved to blameLine as a result.

…iedAndDateInfo' of https://github.com/logical-1985516/RepoSense into 2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModifiedAndDateInfo

…meAuthorModifiedAndDateInfo

…iedAndDateInfo' of https://github.com/logical-1985516/RepoSense into 2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModifiedAndDateInfo

gok99

Thanks for the updates! Should be good to go after the final few comments are addressed.

gok99 · 2024-08-14T05:45:52Z

src/main/java/reposense/git/GitBlame.java

     */
-    private static GitBlameLineInfo processGitBlameResultLine(String blameResult) {
-        String[] blameResultLines = StringsUtil.NEWLINE.split(blameResult);
+    private static GitBlameLineInfo processGitBlameResultLine(String[] blameResultLines, String timeOption) {


I'd prefer to use a boolean for timeOption since it doesn't seem like there are likely to be new options in git in the future.

gok99 · 2024-08-14T05:47:02Z

src/main/java/reposense/git/GitBlame.java

@@ -5,6 +5,9 @@



Could you add / update tests for functions / flags you've added here?

…meAuthorModifiedAndDateInfo

github-actions · 2024-09-14T00:18:54Z

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

github-actions · 2024-09-21T00:19:20Z

This PR was closed because it has been marked as stale for 7 days with no activity.
Feel free to reopen this PR if you would like to continue working on it.

gok99 · 2024-09-21T07:21:04Z

@logical-1985516 Are you planning to wrap up this PR and #2238? I think this PR is mostly good to merge and is just pending some updates to tests.

logical-1985516 · 2024-09-22T06:04:43Z

Hi @gok99, for this PR, I may be able to wrap up this PR within next week, if I have the time.
However, I probably would not wrap up PR #2238. Sorry about that.

logical-1985516 added 3 commits July 1, 2024 00:31

Replace string wrangling with blameLine

0f8de06

Fix lineNumber argument for blameLine and commitDate

8c74f33

Improve variable name, add comments and replace magic numbers

cd69a96

github-actions bot requested a deployment to dashboard-2232 July 3, 2024 16:29 Abandoned

github-actions bot requested a deployment to docs-2232 July 3, 2024 16:29 Abandoned

ckcherry23 requested a review from a team July 3, 2024 16:54

logical-1985516 changed the title ~~2196 use git blame line info for aggregate blame author modified and date info~~ [#2196] Use git blame line info for aggregate blame author modified and date info Jul 4, 2024

Replace commitHash in blameLine with "" to return all blame lines

f8ddc62

github-actions bot requested a deployment to dashboard-2232 July 6, 2024 08:05 Abandoned

github-actions bot requested a deployment to docs-2232 July 6, 2024 08:05 Abandoned

Edit commitHash to now be returned from blameLineInfo for abstraction

72b1f89

ckcherry23 mentioned this pull request Jul 6, 2024

Use GitBlameLineInfo for processing git blame output in aggregateBlameAuthorModifiedAndDateInfo #2196

Open

logical-1985516 added 2 commits July 6, 2024 22:03

Add variable commitDateInMs for better readability

92ccb77

Rename method to be in seconds and change to commit-time in blameLine

c0c78a6

github-actions bot requested a deployment to dashboard-2232 July 6, 2024 15:34 Abandoned

github-actions bot requested a deployment to docs-2232 July 6, 2024 15:34 Abandoned

Remove unused constant COMMIT_TIME_OFFSET

5073ecf

github-actions bot requested a deployment to dashboard-2232 July 6, 2024 15:40 Abandoned

github-actions bot requested a deployment to docs-2232 July 6, 2024 15:40 Abandoned

logical-1985516 added 2 commits July 6, 2024 23:50

Remove unused constants

310856e

Change milliseconds to seconds

5b6caf0

github-actions bot requested a deployment to dashboard-2232 July 6, 2024 15:54 Abandoned

github-actions bot requested a deployment to docs-2232 July 6, 2024 15:54 Abandoned

Merge branch 'master' into 2196-use-GitBlameLineInfo-for-aggregateBla…

b869ba1

…meAuthorModifiedAndDateInfo

github-actions bot requested a deployment to dashboard-2232 July 14, 2024 15:56 Abandoned

github-actions bot requested a deployment to docs-2232 July 14, 2024 15:56 Abandoned

Merge branch 'master' into 2196-use-GitBlameLineInfo-for-aggregateBla…

eab3489

…meAuthorModifiedAndDateInfo

github-actions bot temporarily deployed to dashboard-2232 August 4, 2024 05:25 Inactive

github-actions bot temporarily deployed to docs-2232 August 4, 2024 05:25 Inactive

gok99 requested changes Aug 4, 2024

View reviewed changes

src/main/java/reposense/git/GitBlame.java Outdated Show resolved Hide resolved

src/main/java/reposense/git/GitBlame.java Outdated Show resolved Hide resolved

logical-1985516 added 3 commits August 10, 2024 12:02

Update blameFile to perform blame; abstract out processing in blameFile

96eaf57

Merge branch '2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModif…

82bb6f7

…iedAndDateInfo' of https://github.com/logical-1985516/RepoSense into 2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModifiedAndDateInfo

github-actions bot requested a deployment to dashboard-2232 August 10, 2024 04:53 Abandoned

github-actions bot requested a deployment to docs-2232 August 10, 2024 04:53 Abandoned

Merge branch 'master' into 2196-use-GitBlameLineInfo-for-aggregateBla…

d1a3cf8

…meAuthorModifiedAndDateInfo

github-actions bot requested a deployment to dashboard-2232 August 10, 2024 04:53 Abandoned

github-actions bot requested a deployment to docs-2232 August 10, 2024 04:53 Abandoned

logical-1985516 added 2 commits August 10, 2024 12:55

Use getGitBlameFileResult in FileInfoAnalyzer for abstraction

2ab32d3

Merge branch '2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModif…

f843539

…iedAndDateInfo' of https://github.com/logical-1985516/RepoSense into 2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModifiedAndDateInfo

github-actions bot temporarily deployed to dashboard-2232 August 10, 2024 04:57 Inactive

github-actions bot temporarily deployed to docs-2232 August 10, 2024 04:57 Inactive

gok99 requested changes Aug 14, 2024

View reviewed changes

Merge branch 'master' into 2196-use-GitBlameLineInfo-for-aggregateBla…

972f0e2

…meAuthorModifiedAndDateInfo

github-actions bot temporarily deployed to dashboard-2232 August 14, 2024 05:49 Inactive

github-actions bot temporarily deployed to docs-2232 August 14, 2024 05:49 Inactive

github-actions bot added the Stale label Sep 14, 2024

github-actions bot closed this Sep 21, 2024

gok99 reopened this Sep 21, 2024

gok99 removed the Stale label Sep 21, 2024

github-actions bot deployed to dashboard-2232 September 21, 2024 07:17 View deployment

github-actions bot deployed to docs-2232 September 21, 2024 07:17 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#2196] Use git blame line info for aggregate blame author modified and date info #2232

[#2196] Use git blame line info for aggregate blame author modified and date info #2232

logical-1985516 commented Jul 3, 2024 •

edited

Loading

logical-1985516 commented Jul 7, 2024 •

edited

Loading

logical-1985516 commented Jul 15, 2024

damithc commented Jul 15, 2024

logical-1985516 commented Jul 17, 2024

gok99 left a comment

gok99 Aug 14, 2024

gok99 Aug 14, 2024

github-actions bot commented Sep 14, 2024

github-actions bot commented Sep 21, 2024

gok99 commented Sep 21, 2024

logical-1985516 commented Sep 22, 2024

[#2196] Use git blame line info for aggregate blame author modified and date info #2232

Are you sure you want to change the base?

[#2196] Use git blame line info for aggregate blame author modified and date info #2232

Conversation

logical-1985516 commented Jul 3, 2024 • edited Loading

Proposed commit message

Other information

logical-1985516 commented Jul 7, 2024 • edited Loading

logical-1985516 commented Jul 15, 2024

damithc commented Jul 15, 2024

logical-1985516 commented Jul 17, 2024

gok99 left a comment

Choose a reason for hiding this comment

gok99 Aug 14, 2024

Choose a reason for hiding this comment

gok99 Aug 14, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 14, 2024

github-actions bot commented Sep 21, 2024

gok99 commented Sep 21, 2024

logical-1985516 commented Sep 22, 2024

logical-1985516 commented Jul 3, 2024 •

edited

Loading

logical-1985516 commented Jul 7, 2024 •

edited

Loading