Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typing_extensions #170

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Sep 6, 2023

Fixes DX-215

Why

What changed

  • Updated pyprojecet.toml to pin typing_extensions to be any 4.x.x release
  • Ran poetry lock

Test plan

  • CI passes
  • Make a project that imports the replit-py release and typing-extensions and see it doesn't fail

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

This is not fully backward compatible. It is possible that other Python packages have version bounds that are incompatible with this. However, they should be able to use poetry to choose an older version of this package.

@ryantm ryantm requested a review from a team as a code owner September 6, 2023 22:48
@ryantm ryantm requested review from cdmistman and removed request for a team September 6, 2023 22:48
Why
===
* The old version pin was incompatible with newer libraries
* #125

What changed
===
* Updated pyprojecet.toml to pin typing_extensions to be any 4.x.x release
* Ran poetry lock

Test plan
===
* CI passes
* Make a project that imports the replit-py release and
typing-extensions and see it doesn't fail
@ryantm ryantm changed the title updat typing_extensions update typing_extensions Sep 6, 2023
@ryantm ryantm force-pushed the rtm-9-6-update-typing-extensions branch from 050000f to 7a185a8 Compare September 6, 2023 22:49
@cdmistman
Copy link
Contributor

lgtm
image

@cdmistman cdmistman merged commit 378c83d into master Sep 7, 2023
3 checks passed
@cdmistman cdmistman deleted the rtm-9-6-update-typing-extensions branch September 7, 2023 18:11
@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Incidental change that should not impact released library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants