Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[identity] Update to include subclusters, user IDs, deployments #165

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

lhchavez
Copy link
Contributor

@lhchavez lhchavez commented Sep 5, 2023

Why

We want to be able to track when an identity token comes from a particular subcluster or deployment.

What changed

This change adds that functionality.

Test plan

PASSWORD=secret poetry run python -m unittest tests/test_identity.py

Rollout

  • This is fully backward and forward compatible

@lhchavez lhchavez requested a review from a team as a code owner September 5, 2023 23:51
@lhchavez lhchavez requested review from cdmistman and removed request for a team September 5, 2023 23:51
@lhchavez lhchavez force-pushed the lh-identity-subclusetr-deployments-and-user-id branch 4 times, most recently from 0f98193 to 70910d9 Compare September 6, 2023 02:50
We want to be able to track when an identity token comes from a
particular subcluster or deployment.

This change adds that functionality.
@lhchavez lhchavez force-pushed the lh-identity-subclusetr-deployments-and-user-id branch from 70910d9 to 97bda83 Compare September 6, 2023 02:54
@lhchavez lhchavez merged commit 2a39338 into master Sep 6, 2023
3 checks passed
@lhchavez lhchavez deleted the lh-identity-subclusetr-deployments-and-user-id branch September 6, 2023 03:00
@blast-hardcheese blast-hardcheese added the enhancement New feature or request label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants