Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries when fetching data from DB #149

Merged
merged 13 commits into from
Jul 18, 2023
Merged

Add retries when fetching data from DB #149

merged 13 commits into from
Jul 18, 2023

Conversation

brenoafb
Copy link
Contributor

@brenoafb brenoafb commented Jul 6, 2023 •
edited
Loading

Requests can occasionally fail due to transient network issues. One way to fix this is by retrying idempotent requests with exponential backoff between each retry.

This PR adds a retry_count field to the Database and AsyncDatabase classes that defines the maximum amount of times a database fetch is retried.

@brenoafb brenoafb marked this pull request as ready for review July 10, 2023 12:52
lhchavez
lhchavez reviewed Jul 10, 2023
View reviewed changes
src/replit/database/database.py Outdated Show resolved Hide resolved
src/replit/database/database.py Outdated Show resolved Hide resolved
src/replit/database/database.py Outdated Show resolved Hide resolved
lhchavez
lhchavez approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but wait for Ryan's resolution of the last remaining thread.

ryantm
ryantm approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that library really cleans it up.

@brenoafb brenoafb requested a review from a team as a code owner July 18, 2023 13:31
@brenoafb brenoafb requested review from airportyh and removed request for a team July 18, 2023 13:31
brenoafb and others added 13 commits July 18, 2023 13:38
@brenoafb
parent cee2529
23dcc1c 
author brenoafb <breno.afb@gmail.com> 1680894638 +0000
committer Replit user <> 1688675354 +0000

Load Replit DB URL from a file

Add option to auth into DB using Repl Identity

Remove print

Update version

Add retries to get requests
Add exponential backoff, treat KeyError differently
523ef2b
Import packages
63ae9f8
remove print
a5c1bae
Log a message if DB fails to initialize
ac375fb
@brenoafb @lhchavez
Update src/replit/database/database.py
eaf7983 
Co-authored-by: lhchavez <lhchavez@lhchavez.com>
Use type in init param
5eded57
use aiohttp_retry for retries in AsyncDatabase
f284944
use retry adapter for sync requests
30b9897
remove retry_count slot in [Async]Database
0988108
Update package version
e7a6598
update poetry.lock
14543e8
update poetry.lock
a45edc6
@masad-frost masad-frost merged commit a2ef4f3 into master Jul 18, 2023
@masad-frost masad-frost deleted the bb-retries branch July 18, 2023 14:05
@blast-hardcheese blast-hardcheese added the enhancement New feature or request label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@lhchavez lhchavez lhchavez approved these changes

@airportyh airportyh Awaiting requested review from airportyh airportyh is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brenoafb @ryantm @lhchavez @blast-hardcheese @masad-frost