Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #130

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Update README.md #130

merged 3 commits into from
Feb 28, 2024

Conversation

techpixel
Copy link
Contributor

In the README, I find that this is a little bit misleading.

A Flask–based application framework for accelerating development on the platform.

This change accurately represents the feature as an interface to replit:

A Flask interface to Replit's User Authetication service

@spencerpogo
Copy link
Contributor

it's more than just auth though. can you elaborate on what is misleading?

@techpixel
Copy link
Contributor Author

techpixel commented May 26, 2022

From what I can gather from the documentation, the "web" part only consists of an interface to replit auth and a few helper /wrapper functions. I can't discern any of these features from "application framework".

@spencerpogo
Copy link
Contributor

Well "vague" is different from "misleading." I think the current wording is sufficient to "draw a user in." While I'm willing to change it, I think that your wording doesn't cover the full scope of replit.web.

@techpixel
Copy link
Contributor Author

How about:

Tools and utilities for Flask Web Development, including an interface to Replit's User Authetication service

It points to the wrappers and helper functions while also mentioning the Auth interface.

@spencerpogo
Copy link
Contributor

Sounds good. If you update that sentence as you mentioned I'll merge

@techpixel
Copy link
Contributor Author

Sentence was updated and is ready to merge.

@techpixel
Copy link
Contributor Author

Will this merge?

@lafkpages
Copy link

Will it?

@techpixel
Copy link
Contributor Author

It appears this library stopped getting updates near the time this PR was made, so likely not.

Copy link
Collaborator

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry for the lack of response up until now!

@techpixel techpixel requested a review from a team as a code owner February 28, 2024 00:15
@techpixel techpixel requested review from airportyh and removed request for a team February 28, 2024 00:15
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) February 28, 2024 00:15
@blast-hardcheese blast-hardcheese merged commit 2448453 into replit:master Feb 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants