Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for issue #22 #23

Merged
merged 2 commits into from
Jun 20, 2013
Merged

Test for issue #22 #23

merged 2 commits into from
Jun 20, 2013

Conversation

tclancy
Copy link
Contributor

@tclancy tclancy commented Jun 18, 2013

Test to show problem described in #22: Conditional Comments are getting partially escaped.

@tclancy
Copy link
Contributor Author

tclancy commented Jun 19, 2013

How's this?

On Wed, Jun 19, 2013 at 2:33 PM, Tanner Netterville <
notifications@github.com> wrote:

Let's simplify the test case to test only that < and > are not html
ampersand escaped within comments.


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-19704098
.

@rennat
Copy link
Owner

rennat commented Jun 20, 2013

that will do nicely, merging it into my local to see if we can either fix
it or compensate for another beautiful soup bug.

On Wed, Jun 19, 2013 at 4:53 PM, Tom Clancy notifications@github.51.alwrote:

How's this?

On Wed, Jun 19, 2013 at 2:33 PM, Tanner Netterville <
notifications@github.com> wrote:

Let's simplify the test case to test only that < and > are not html
ampersand escaped within comments.


Reply to this email directly or view it on GitHub<
https://github.com/rennat/pynliner/pull/23#issuecomment-19704098>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/23#issuecomment-19717785
.

@tclancy
Copy link
Contributor Author

tclancy commented Jun 20, 2013

If you want to point me at where to look, I'm happy to help. My problem (well, one of them) is it's been a decade since I've really worked with BS (e.g. writing a processor) and the syntax is just different enough it throws me off.

@rennat rennat merged commit aab72f5 into rennat:master Jun 20, 2013
@rennat
Copy link
Owner

rennat commented Jun 20, 2013

I've merged this in and added the ability to clean up after beautiful soup in this case.

It turns out this is just the behavior of BeautifulSoup and I didn't want to get into it's internals because eventually Pynliner will abandon BeautifulSoup as a requirement (it will be a big version jump.)

This is fixed but it is not an incredibly efficient process so it's disabled by default. To enable it just instantiate your Pynliner object with the keyword argument allow_conditional_comments=True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants