Python3 documentation/scripts update #40
Conversation
There was a problem hiding this comment.
The changes to call 'python3' instead of 'python' aren't really necessary, since 'python' should be linked to the appropriate python3 binary, but it works either way.
The change to requirements.txt needs to be reverted (or the line removed entirely) and if you add the change I requested to the readme, this should be good for merging.
There was a problem hiding this comment.
This change is unnecessary, and actually breaks the installation with python3. The logging module is included as part of the standard python3 library and so doesn't need to be installed, which is what this flagged.
There was a problem hiding this comment.
This is all mostly fine. Though I really don't like being forced into a virtual environment, there is no good way around it.
Needs an extra bit to add the venv to the path, which will simplify troubleshooting and manual running on the controller, since it will bypass the need to source the venv. Something like this added to the bottom of .bashrc
export PATH="/home/user_name/remotv/.venv/bin:$PATH"
Should save time and trouble since a lot of the users don't know anything about python or virtual environments.
|
@Nocturnal42 Thank you for the review! I made the requested changes. Please let me know if you see anything else that needs to be reconciled. |
Changed startup scripts and instructions to python3. Tested on a raspberry pi.