feat(Radio/Select): Spread x-jsf-presentation value to option root

[sandrina-p]

Example

For example, given the following JSON Schema, where each oneOf contains a x-jsf-presentation:

{
  properties: {
    health_perks: {
      title: 'Health perks',
      oneOf: [
        {
          const: 'basic',
          title: 'Basic',
          'x-jsf-presentation': {
            cost: '$30.00/mo',
          },
          'x-another': 'extra-thing',
        },
        {
          const: 'standard',
          title: 'Standard',
          'x-jsf-presentation': {
            cost: '$50.00/mo',
          },
        }
      ],
      'x-jsf-presentation': {
        inputType: 'radio',
        layout: "vertical"
      },
      type: 'string',
    },
  },
}

Without this PR, to access the cost of each option, you'd need to do:

const { fields } = createHeadlessForm(demoAbove);

const cost = fields[0].options[0]['x-jsf-presentation'].cost

Now, you can access it directly with:

const cost = fields[0].options[0].cost

In other words, now we move the x-jsf-presentation's data to the closest parent, removing the key itself, similar to how we already do with the root (check layout to compare). The fields[0] would look like this:

{
  "name": "health_perks",
  "label": "Health perks",
  "options": [
    {
      "label": "Basic",
      "value": "basic",
      "cost": "$30.00/mo", // <-- moved to parent
      "x-another": "extra-thing" // <-- still accepts any other arbitrary key
    },
    {
      "label": "Standard",
      "value": "standard",
      "cost": "$50.00/mo"
    }
  ],
  "inputType": "radio",
  "jsonType": "string",
  "layout": "vertical"  // <-- the new behavior is similar to this existing one in the field root
}

---

Related

• Linear issue (private)
• Slack thread (private)

[sandrina-p]

Ready for review :)

[brennj]

for consistency sake in regards to internal discussions, should we wrap this in meta just to have everything aligned in case someone combs through the code?

[brennj]

(this is the only comment i have, i'm happy with this otherwise)

[sandrina-p]

Yes, done!

[brennj]

lets go!